feat(RichTextEditor): format toolbar [WPB-12089] #18398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18398 +/- ##
==========================================
- Coverage 46.27% 46.19% -0.09%
==========================================
Files 845 861 +16
Lines 26432 26593 +161
Branches 5995 6022 +27
==========================================
+ Hits 12232 12284 +52
- Misses 12665 12770 +105
- Partials 1535 1539 +4 |
…of commenting the issue
przemvs
reviewed
Dec 6, 2024
przemvs
reviewed
Dec 6, 2024
src/script/components/InputBar/components/ImageUploadButton/ImageUploadButton.test.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Dec 6, 2024
src/script/components/InputBar/components/ImageUploadButton/ImageUploadButton.test.tsx
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Dec 6, 2024
...script/components/RichTextEditor/components/FormatToolbar/useHeadingState/useHeadingState.ts
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Dec 6, 2024
...script/components/RichTextEditor/components/FormatToolbar/useToolbarState/useToolbarState.ts
Outdated
Show resolved
Hide resolved
…unnecessary useCallback
| > | ||
| <ul | ||
| className={cx('controls-right buttons-group input-bar-buttons', { | ||
| 'controls-right-shrinked': textValue.length !== 0, |
There was a problem hiding this comment.
Suggested change
| 'controls-right-shrinked': textValue.length !== 0, | |
| 'controls-right-shrinked': !!textValue.length, |
Comment on lines
+606
to
+611
| onEscape={() => { | ||
| if (editedMessage) { | ||
| cancelMessageEditing(true); | ||
| } else if (replyMessageEntity) { | ||
| cancelMessageReply(); | ||
| } |
There was a problem hiding this comment.
maybe extract to a function
| export const FormatTextButton = ({isActive, onClick}: FormatTextButtonProps) => { | ||
| return ( | ||
| <button | ||
| className={cx(`controls-right-button buttons-group-button-left`, { |
There was a problem hiding this comment.
Suggested change
| className={cx(`controls-right-button buttons-group-button-left`, { | |
| className={cx('controls-right-button buttons-group-button-left', { |
przemvs
reviewed
Dec 12, 2024
src/script/components/InputBar/hooks/useEmojiPicker/useEmojiPicker.ts
Outdated
Show resolved
Hide resolved
przemvs
reviewed
Dec 12, 2024
src/script/components/RichTextEditor/components/FormatToolbar/FormatToolbar.tsx
Outdated
Show resolved
Hide resolved
thisisamir98
approved these changes
Dec 12, 2024
przemvs
approved these changes
Dec 12, 2024
|
paulwire
added
the
echoes: product-roadmap/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new rich text editor that allows users to edit their message visually before sending it, contains options: heading (h1), bold, italic, strikethrough, lists (ordered & unordered), and code.
Figma Designs
What's changed?
What's missing?
Tests. It turned out, that testing the Lexical-related code isn't simple. It's because of the poor support for the
contenteditablein JSDOM (issue no.1, and no.2), and lack of other utilities from the Lexical itself, more info. We will add end-to-end tests with QA guidance to ensure the feature works properly.Screenshots/Screencast (for UI changes)
Text formatting:
Screen.Recording.2024-12-03.at.08.01.05.mov
Message editing:
Screen.Recording.2024-12-03.at.08.03.51.mov
Message editing (rich, long):
Screen.Recording.2024-12-04.at.10.24.51.mov
Inserting emoji:
Screen.Recording.2024-12-03.at.08.04.52.mov
Reply to message preview:
Screen.Recording.2024-12-04.at.10.20.37.mov
Default view, large viewport:
Default view, small viewport:
Rich text view, large viewport:
Rich text view, small viewport:
Checklist